Cosmos CFP: fix for race condition issue #6205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the lease documents.
…een updated while we are trying to write the current state such as check-pointing the continuation token.
# Conflicts: # sdk/cosmos/changelog/README.md
kushagraThapar
approved these changes
Nov 7, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
Some suggestions around logger.error and logger.debug
otherwise looks good to me.
...src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/AutoCheckpointer.java
Show resolved
Hide resolved
...src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/AutoCheckpointer.java
Show resolved
Hide resolved
.../src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/DefaultObserver.java
Show resolved
Hide resolved
Member
|
/azp run java - cosmos - tests |
moderakh
reviewed
Nov 7, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
some minor questions and comments
...src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/AutoCheckpointer.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/AutoCheckpointer.java
Outdated
Show resolved
Hide resolved
...ain/java/com/azure/data/cosmos/internal/changefeed/implementation/LeaseStoreManagerImpl.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/data/cosmos/internal/changefeed/implementation/PartitionProcessorImpl.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/data/cosmos/internal/changefeed/implementation/PartitionProcessorImpl.java
Show resolved
Hide resolved
...in/java/com/azure/data/cosmos/internal/changefeed/implementation/PartitionProcessorImpl.java
Show resolved
Hide resolved
Member
|
/azp run java - cosmos - tests |
moderakh
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeFeedProcessor: fix a race condition issue where the lease document has been updated while we are trying to write the current state like when check-pointing the continuation token.